diff --git a/packages/codemirror/package.json b/packages/codemirror/package.json index e20dd1d..6d72e60 100644 --- a/packages/codemirror/package.json +++ b/packages/codemirror/package.json @@ -1,6 +1,6 @@ { "name": "@kevisual/codemirror", - "version": "0.0.1", + "version": "0.0.2", "description": "", "main": "dist/editor.js", "privite": false, diff --git a/packages/codemirror/src/editor.json.ts b/packages/codemirror/src/editor.json.ts index 4c9aef9..5a40234 100644 --- a/packages/codemirror/src/editor.json.ts +++ b/packages/codemirror/src/editor.json.ts @@ -10,7 +10,7 @@ let editor: EditorView = null; */ const createEditorInstance = (el?: HTMLDivElement) => { if (editor && el) { - editor.dom.appendChild(el); + el.appendChild(editor.dom); return editor; } else if (editor) { return editor; @@ -19,6 +19,7 @@ const createEditorInstance = (el?: HTMLDivElement) => { extensions: [basicSetup, json()], parent: el || document.body, }); + editor.dom.style.height = '100%'; return editor; }; @@ -28,10 +29,12 @@ const createEditorInstance = (el?: HTMLDivElement) => { * @returns */ export const createEditor = (el: HTMLDivElement) => { - return new EditorView({ + const editor = new EditorView({ extensions: [basicSetup, json()], parent: el || document.body, }); + editor.dom.style.height = '100%'; + return editor; }; export { editor, createEditorInstance }; diff --git a/packages/codemirror/src/editor.ts b/packages/codemirror/src/editor.ts index 191c2e1..1aede3d 100644 --- a/packages/codemirror/src/editor.ts +++ b/packages/codemirror/src/editor.ts @@ -14,7 +14,7 @@ type CreateOpts = { */ const createEditorInstance = (el?: HTMLDivElement, opts?: CreateOpts) => { if (editor && el) { - editor.dom.appendChild(el); + el.appendChild(editor.dom); return editor; } else if (editor) { return editor; @@ -24,6 +24,7 @@ const createEditorInstance = (el?: HTMLDivElement, opts?: CreateOpts) => { extensions: [basicSetup, javascript({ jsx, typescript })], parent: el || document.body, }); + editor.dom.style.height = '100%'; return editor; }; @@ -33,10 +34,12 @@ const createEditorInstance = (el?: HTMLDivElement, opts?: CreateOpts) => { * @returns */ export const createEditor = (el: HTMLDivElement, opts?: CreateOpts) => { - return new EditorView({ + const editor = new EditorView({ extensions: [basicSetup, javascript({ jsx: opts?.jsx, typescript: opts?.typescript })], parent: el || document.body, }); + editor.dom.style.height = '100%'; + return editor; }; export { editor, createEditorInstance }; diff --git a/packages/ui/src/components/modal/modal.ts b/packages/ui/src/components/modal/modal.ts index f05cede..73af023 100644 --- a/packages/ui/src/components/modal/modal.ts +++ b/packages/ui/src/components/modal/modal.ts @@ -36,6 +36,7 @@ export type DefaultStyle = { } & T; export class Modal { + static rootClassName = '#ui-modal-list'; root: HTMLDivElement; id: string; modalElement?: HTMLDivElement;